search

filecoin-project / fvm-starter-kit-deal-making

Full dapp starter kit for automating Filecoin deal making
Apache License 2.0
38 stars 14 forks source link

filecoin library configured #34

Closed lordshashank closed 2 months ago

lordshashank commented 4 months ago

With zondax library deprecated and filecoin-solidity-library having recent changes, shifting the starter kit to filecoin library with latest dependency version to make it clone and deployable.

lordshashank commented 2 months ago

@xBalbinus , would be great if you could review this.

xBalbinus commented 2 months ago

LGTM; non-blocking, but might not want to add hard-coded gas configs, and let the user set as a constant. Can default to your existing ones if nothing is set.

lordshashank commented 2 months ago

Removed that, transactions seem to be going without that now, was not working before.