search

filecoin-project / github-mgmt

0 stars 6 forks source link

Update filecoin-project.yml to make this repo public #46

Closed BigLep closed 3 months ago

BigLep commented 4 months ago

Closes https://github.com/filecoin-project/github-mgmt/issues/45

~NOTE: wait to merge until https://github.com/filecoin-project/community/discussions/710 is given some time for comment.~

Summary

Make this repo public per https://github.com/filecoin-project/github-mgmt/issues/45

Why do you need this?

See https://github.com/filecoin-project/github-mgmt/issues/45

Reviewer's Checklist

github-actions[bot] commented 4 months ago

The following access changes will be introduced as a result of applying the plan:

Access Changes ``` There will be no access changes ```
github-actions[bot] commented 4 months ago

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

filecoin-project ``` Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # github_repository.this["github-mgmt"] will be updated in-place ~ resource "github_repository" "this" { id = "github-mgmt" name = "github-mgmt" ~ visibility = "private" -> "public" # (31 unchanged attributes hidden) + security_and_analysis { + secret_scanning { + status = "enabled" } + secret_scanning_push_protection { + status = "enabled" } } # (1 unchanged block hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ```
BigLep commented 3 months ago

@galargh : I think we'd be good to flip this public now given no pushback in https://github.com/filecoin-project/community/discussions/710

galargh commented 3 months ago

After the merge, let's require approval for all outside collaborators. This setting is not available for private repositories - that's why it wasn't set before.

BigLep commented 3 months ago

@galargh : I have merged. I don't have the ability to adjust setting in the UI since I'm not an org owner/admin and I currently only have push access. (I'll give github-mgmt stewards maintain or admin permissions to this repo when handling https://github.com/filecoin-project/github-mgmt/issues/47 . Are you ok to handle in the meantime?