search

filecoin-project / go-amt-ipld

Implementation of an array mapped trie using go and ipld
Other
9 stars 15 forks source link

parallel iter element #12

Closed hunjixin closed 3 years ago

hunjixin commented 4 years ago

parallel iter element

hunjixin commented 4 years ago

@whyrusleeping

warpfork commented 3 years ago

I did some brief code review on this, but am also not the maintainer of this repo, and am not sure what the trajectory for pursuing this work would be.

I'm not sure there's going to be a desire from the maintainers of this repo to merge additional code (which means additional maintenance burden for them) without a very compelling reason.

A PR for parallelization is especially tricky because A) a parallelization strategy really needs careful design; and B) a parallelization system needs careful benchmarking to be sure that it's actually improving things.

jennijuju commented 3 years ago

@hunjixin Thank you for contributing, base on @warpfork and @Stebalien 's evaluation, I'm gonna close this pr for now!