filecoin-project / go-amt-ipld

Implementation of an array mapped trie using go and ipld
Other
9 stars 15 forks source link

Update cbor-gen #87

Closed rvagg closed 2 months ago

rvagg commented 8 months ago

Ref: https://github.com/whyrusleeping/cbor-gen/pull/92

@Stebalien this is that problem you mentioned over in https://github.com/whyrusleeping/cbor-gen/pull/92; but the problem still exists that you either have to regenerate across the libraries like this, or you have to have to consistently configure in gen.go everywhere you use it to avoid conflicts. 🤷

codecov-commenter commented 8 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (ba45dc7) 62.85% compared to head (dd81127) 63.36%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-amt-ipld/pull/87/graphs/tree.svg?width=650&height=150&src=pr&token=X9N1gLwHJY&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-amt-ipld/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## master #87 +/- ## ========================================== + Coverage 62.85% 63.36% +0.51% ========================================== Files 8 8 Lines 1346 1365 +19 ========================================== + Hits 846 865 +19 Misses 348 348 Partials 152 152 ``` | [Files](https://app.codecov.io/gh/filecoin-project/go-amt-ipld/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [internal/cbor\_gen.go](https://app.codecov.io/gh/filecoin-project/go-amt-ipld/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-aW50ZXJuYWwvY2Jvcl9nZW4uZ28=) | `37.08% <58.97%> (+6.16%)` | :arrow_up: |
rvagg commented 8 months ago

Marking as draft until issues raised in https://github.com/filecoin-project/go-state-types/pull/242 are resolved

rvagg commented 8 months ago

Updated for master now that https://github.com/whyrusleeping/cbor-gen/pull/94 is merged; but this is also now low priority as we no longer have breakage and the diff is relatively meaningless