search

filecoin-project / go-bitfield

Other
4 stars 8 forks source link

Add JSON un/marshaling to RLE, use it to un/marshal BitFields #13

Closed arajasek closed 4 years ago

arajasek commented 4 years ago

Motivation: https://github.com/filecoin-project/lotus/pull/2050#pullrequestreview-432214471

Kubuxu commented 4 years ago

We should not have 0 length run at all, even at the start.

Kubuxu commented 4 years ago

As in we should not add the initital run if it has length 0.

arajasek commented 4 years ago

@Kubuxu Yup, we don't add an initial run length of 0, the "exception" is just that we don't fail on a zero-length run if it's the first run.