codecov-commenter
commented
2 years ago Codecov Report
Merging #339 (a6fdac1) into v2 (c833220) will decrease coverage by
16.03%. The diff coverage is36.80%.
@@ Coverage Diff @@
## v2 #339 +/- ##
===========================================
- Coverage 71.18% 55.14% -16.04%
===========================================
Files 21 26 +5
Lines 2717 2778 +61
===========================================
- Hits 1934 1532 -402
- Misses 576 1081 +505
+ Partials 207 165 -42 | Impacted Files | Coverage Δ | |
|---|---|---|
| channels/channels_fsm.go | 71.25% <ø> (-0.18%) |
:arrow_down: |
| transport/graphsync/graphsync.go | 0.00% <0.00%> (-76.80%) |
:arrow_down: |
| transport/graphsync/hooks.go | 0.00% <0.00%> (ø) |
|
| transport/graphsync/receiver.go | 0.00% <0.00%> (ø) |
|
| impl/events.go | 46.30% <33.33%> (-40.75%) |
:arrow_down: |
| impl/restart.go | 54.90% <54.54%> (-5.60%) |
:arrow_down: |
| transport/graphsync/utils.go | 59.61% <59.61%> (ø) |
|
| transport/helpers/network/interface.go | 60.00% <60.00%> (ø) |
|
| transport/helpers/network/libp2p_impl.go | 64.62% <61.06%> (ø) |
|
| channelmonitor/channelmonitor.go | 74.05% <66.66%> (-1.28%) |
:arrow_down: |
| ... and 19 more |
Goals
I know, a tracking branch on a tracking branch? It's awful. But the transport refactors have largely been reviewed even though I'd rather not merge till it's all done.
Anyway, hopefully the main final PRs will go up shortly, against this one, and the then we can review it as a whole and merge it.