search

filecoin-project / go-data-transfer

Data Transfer Shared Component for go-filecoin & go-lotus
Other
39 stars 17 forks source link

Make states/events printable #366

Closed hannahhoward closed 1 year ago

hannahhoward commented 1 year ago

Goals

Resolves a long standing Quality Of Life improvement -- adds a fmt.Stringer methods to status and events so they appear in readable form when the state machine fails

I have no idea why I didn't do this earlier.

codecov-commenter commented 1 year ago

Codecov Report

Merging #366 (c3b49ab) into master (106231c) will decrease coverage by 5.79%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366/graphs/tree.svg?width=650&height=150&src=pr&token=M4Th4q6xd3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## master #366 +/- ## ========================================== - Coverage 67.12% 61.34% -5.79% ========================================== Files 23 30 +7 Lines 2902 3182 +280 ========================================== + Hits 1948 1952 +4 - Misses 725 1001 +276 Partials 229 229 ``` | [Impacted Files](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [events.go](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-ZXZlbnRzLmdv) | `100.00% <100.00%> (ø)` | | | [statuses.go](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-c3RhdHVzZXMuZ28=) | `10.00% <100.00%> (ø)` | | | [transferconfig.go](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-dHJhbnNmZXJjb25maWcuZ28=) | `0.00% <0.00%> (ø)` | | | [errors.go](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-ZXJyb3JzLmdv) | `0.00% <0.00%> (ø)` | | | [types.go](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-dHlwZXMuZ28=) | `0.00% <0.00%> (ø)` | | | [manager.go](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-bWFuYWdlci5nbw==) | `0.00% <0.00%> (ø)` | | | [types\_cbor\_gen.go](https://codecov.io/gh/filecoin-project/go-data-transfer/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-dHlwZXNfY2Jvcl9nZW4uZ28=) | `0.00% <0.00%> (ø)` | |