search

filecoin-project / go-f3

Golang implementation of Fast Finality in Filecoin (F3)
Apache License 2.0
6 stars 4 forks source link

Save/restore dynamic manifest on restart #429

Closed Stebalien closed 6 days ago

Stebalien commented 2 weeks ago

We don't currently save/restore the latest dynamic manifest on node restart.

https://github.com/filecoin-project/go-f3/blob/3b6ea9e2210365ea22c10cfdaadeb1559a931fb3/manifest/dynamic_manifest.go#L124-L125

masih commented 2 weeks ago

I think we don't need to in practice. The current deployment of Manifest server does this automagically.

The initial manifest (and any modifications to it) are stored on disk via the _deployment of manifest server.

But I hear you in that we could have built-in storage of it on disk? I like keeping the dynamic manifest dumb: in that it just broadcasts whatever it is given in-memory. But no strong feelings.

Stebalien commented 2 weeks ago

I'm talking about the client/lotus. Without it, nodes will start with the wrong instance and wait until the manifest server broadcasts an update before switching. I guess maybe that's fine? But I'd prefer to re-boot into the correct manifest.

masih commented 2 weeks ago

Oh I see; that makes sense 👍

jennijuju commented 1 week ago

@Kubuxu are you picking this up?