Make it possible to coalesce distinct pubsub messages

filecoin-project / go-f3

Golang implementation of Fast Finality in Filecoin (F3)

Apache License 2.0

8 stars 6 forks source link

Make it possible to coalesce distinct pubsub messages #601

Open Stebalien opened 2 weeks ago

Stebalien commented 2 weeks ago

If we split pubsub message IDs into "validation IDs" and "propagation IDs", we'll be able to drop equivalent pubsub messages even if they're not 100% identical.

At the validation layer, use the message hash to deduplicate (make sure to make this work with rebroadcast).
After successful validation, identify the message based on the hash of the gpbft value.
Only propagate messages with unique GPBFT values.

Stebalien commented 2 weeks ago

IIRC, there were two motivations here:

An improved finality certificate protocol. But that can always be punted till later.
Avoiding justification validation. Given #592, I'm not sure if that's still critical. Validation of justification signatures is just as fast as validating the message so, at most, we'd cut validation time by 1/2 (but I'm not sure if that's worth it, also https://github.com/filecoin-project/go-f3/issues/614).

Stebalien commented 1 week ago

We're deferring this because it's not a huge priority, see above.