search

filecoin-project / go-f3

Golang implementation of Fast Finality for Filecoin (F3)
Apache License 2.0
11 stars 7 forks source link

Move fake EC out of production API #641

Closed masih closed 2 months ago

masih commented 2 months ago

Move fake EC, primarily used for testing out of production scope API and into an internal package.

This simplifies the integration code in lotus.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.51%. Comparing base (d58532b) to head (0c88325). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/641/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #641 +/- ## ========================================== - Coverage 79.91% 79.51% -0.41% ========================================== Files 52 52 Lines 4695 4695 ========================================== - Hits 3752 3733 -19 - Misses 593 605 +12 - Partials 350 357 +7 ``` | [Files with missing lines](https://app.codecov.io/gh/filecoin-project/go-f3/pull/641?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [internal/consensus/fake\_ec.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/641?src=pr&el=tree&filepath=internal%2Fconsensus%2Ffake_ec.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-aW50ZXJuYWwvY29uc2Vuc3VzL2Zha2VfZWMuZ28=) | `89.77% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/641/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)