filecoin-project / go-f3

Golang implementation of Fast Finality in Filecoin (F3)
Apache License 2.0
8 stars 6 forks source link

Store & pass the power table by reference #654

Closed Stebalien closed 1 week ago

Stebalien commented 1 week ago

Based on https://github.com/filecoin-project/go-f3/pull/651.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.14%. Comparing base (e3767bf) to head (d4f1327). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
gpbft/participant.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/654/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #654 +/- ## ========================================== - Coverage 79.18% 79.14% -0.05% ========================================== Files 55 55 Lines 4906 4906 ========================================== - Hits 3885 3883 -2 - Misses 640 643 +3 + Partials 381 380 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/filecoin-project/go-f3/pull/654?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [gpbft/gpbft.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/654?src=pr&el=tree&filepath=gpbft%2Fgpbft.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Z3BiZnQvZ3BiZnQuZ28=) | `88.08% <100.00%> (ø)` | | | [gpbft/participant.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/654?src=pr&el=tree&filepath=gpbft%2Fparticipant.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Z3BiZnQvcGFydGljaXBhbnQuZ28=) | `87.22% <0.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/654/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)