search

filecoin-project / go-f3

Golang implementation of Fast Finality in Filecoin (F3)
Apache License 2.0
8 stars 6 forks source link

Remove the unused `terminatedDuringRound` participant field #665

Closed masih closed 5 days ago

masih commented 5 days ago

The terminatedDuringRound is unused; remove it.

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.35%. Comparing base (46a498f) to head (b287115). Report is 5 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/665/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #665 +/- ## ========================================== - Coverage 76.43% 76.35% -0.08% ========================================== Files 65 65 Lines 5393 5392 -1 ========================================== - Hits 4122 4117 -5 - Misses 873 875 +2 - Partials 398 400 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/filecoin-project/go-f3/pull/665?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [gpbft/participant.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/665?src=pr&el=tree&filepath=gpbft%2Fparticipant.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Z3BiZnQvcGFydGljaXBhbnQuZ28=) | `86.12% <ø> (-1.23%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/665/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)