search

filecoin-project / go-f3

Golang implementation of Fast Finality for Filecoin (F3)
Apache License 2.0
11 stars 7 forks source link

Reduce GOGC in fuzz tests #667

Closed masih closed 1 month ago

masih commented 1 month ago

Investigate false negative fuzz test failures due to hitting memory limit by reverting GOGC back to default 100.

Fixes #666

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.26%. Comparing base (46a498f) to head (8d58db6). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/667/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #667 +/- ## ========================================== - Coverage 76.43% 76.26% -0.17% ========================================== Files 65 65 Lines 5393 5393 ========================================== - Hits 4122 4113 -9 - Misses 873 878 +5 - Partials 398 402 +4 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/667/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)
masih commented 1 month ago

Repeated fuzzing 3 times with the changes here and the time it take for the fuzzing to run is more or less the same as the time it takes on main.

All three attempts succeeded.