search

filecoin-project / go-f3

Golang implementation of Fast Finality in Filecoin (F3)
Apache License 2.0
8 stars 6 forks source link

Don't abort if we fail to deliver an alarm and/or start an instance #674

Closed Stebalien closed 1 day ago

Stebalien commented 2 days ago

We may fail to deliver an alarm if we, e.g., don't have a power table we need to participate in that instance. In that case, we should just wait until we get a finality certificate that'll let us advance to an instance we can participate in.

Also, start the first instance at the correct time (which may be in the future if we're rebooting).

Stebalien commented 2 days ago

Note: I'm working on a test locally that'll exercise this (and other things), but I don't want the patch growing too large.

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.20%. Comparing base (c438aa5) to head (48c8860). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
host.go 84.61% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/674/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #674 +/- ## ========================================== - Coverage 76.24% 76.20% -0.04% ========================================== Files 65 65 Lines 5421 5418 -3 ========================================== - Hits 4133 4129 -4 - Misses 884 888 +4 + Partials 404 401 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/filecoin-project/go-f3/pull/674?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [emulator/driver.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/674?src=pr&el=tree&filepath=emulator%2Fdriver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-ZW11bGF0b3IvZHJpdmVyLmdv) | `92.85% <100.00%> (+4.48%)` | :arrow_up: | | [host.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/674?src=pr&el=tree&filepath=host.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-aG9zdC5nbw==) | `67.14% <84.61%> (-1.11%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/674/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)