search

filecoin-project / go-f3

Golang implementation of Fast Finality in Filecoin (F3)
Apache License 2.0
8 stars 6 forks source link

Move redundant top-level singer-marshaller interface #682

Closed masih closed 16 hours ago

masih commented 18 hours ago

The interfaceSignerWithMarshaler is only used by sim package. Remove it from top level gpbft package into unexported sim network implementation.

Unexport simulation NetworkFor since it is returning an unexported type.

codecov[bot] commented 17 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.27%. Comparing base (9556aff) to head (67975c2). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/682/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #682 +/- ## ========================================== - Coverage 76.31% 76.27% -0.04% ========================================== Files 65 65 Lines 5392 5392 ========================================== - Hits 4115 4113 -2 - Misses 882 884 +2 Partials 395 395 ``` | [Files with missing lines](https://app.codecov.io/gh/filecoin-project/go-f3/pull/682?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [gpbft/message\_builder.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/682?src=pr&el=tree&filepath=gpbft%2Fmessage_builder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Z3BiZnQvbWVzc2FnZV9idWlsZGVyLmdv) | `94.87% <ø> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/682/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)