search

filecoin-project / go-f3

Golang implementation of Fast Finality for Filecoin (F3)
Apache License 2.0
12 stars 7 forks source link

Fix golangci-lint warnings since it is still used in `make lint` #711

Closed masih closed 1 month ago

masih commented 1 month ago

Running make lint locally highlights these lint issues which is slightly annoying. Explicitly ignore the error to silence the linter.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.34%. Comparing base (f638813) to head (38666e7). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/711/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/711?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #711 +/- ## ========================================== + Coverage 76.32% 76.34% +0.01% ========================================== Files 69 69 Lines 5584 5584 ========================================== + Hits 4262 4263 +1 + Misses 912 911 -1 Partials 410 410 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/711/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)