search

filecoin-project / go-f3

Golang implementation of Fast Finality for Filecoin (F3)
Apache License 2.0
12 stars 7 forks source link

Fix an off-by-one in the powerstore #736

Closed Stebalien closed 2 weeks ago

Stebalien commented 2 weeks ago

Also fix the test.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.95%. Comparing base (12514c1) to head (cfc5564). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/736/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/736?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #736 +/- ## ========================================== - Coverage 75.18% 74.95% -0.23% ========================================== Files 70 70 Lines 6938 6939 +1 ========================================== - Hits 5216 5201 -15 - Misses 1311 1324 +13 - Partials 411 414 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/filecoin-project/go-f3/pull/736?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [internal/powerstore/powerstore.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/736?src=pr&el=tree&filepath=internal%2Fpowerstore%2Fpowerstore.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-aW50ZXJuYWwvcG93ZXJzdG9yZS9wb3dlcnN0b3JlLmdv) | `61.86% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/736/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)