Have a canonical way to take a FakeEC and build certs from it and/or compare that certs are corresponding to given chain

filecoin-project / go-f3

Golang implementation of Fast Finality for Filecoin (F3)

Apache License 2.0

12 stars 7 forks source link

Have a canonical way to take a FakeEC and build certs from it and/or compare that certs are corresponding to given chain #743

Open Kubuxu opened 2 weeks ago

Kubuxu commented 2 weeks ago

Would prevent the bug in OhShitStore. Provide a way to form certs from FakeEC and/or compare FakeEC with external certs. Provides an extra assertion for testing GPBFT correctness (which we don't really do right now a lot) as well probably simplifies some tests (provide certs to nodes instead of running GPBFT).

rjan90 commented 6 days ago

Test case for the bug that was hit on Calibration. Hope to have that done by 2024-11-20