search

filecoin-project / go-fil-markets

Shared Implementation of Storage and Retrieval Markets for Filecoin Node Implementations
Other
78 stars 59 forks source link

SPs and clients should be able to mark content as not available for retrieval #704

Closed honghaoq closed 2 years ago

willscott commented 2 years ago

@honghaoq you initially wrote the title for this issue to indicate you wanted to be able to prevent indexing/retrieval of specific CIDs. Do you know if that's the right granularity, or if providers/clients want to be able to deny retrieval at a deal level?

LexLuthr commented 2 years ago

The goal is to deny indexing and not the retrieval itself. If deal is not indexed then only the client who made the deal can still retrieve it.

honghaoq commented 2 years ago

The granularity is at deal level! Mayank also flag this to Boost since go-fil-market is deprecating in few months.

willscott commented 2 years ago

The goal is to deny indexing and not the retrieval itself. If deal is not indexed then only the client who made the deal can still retrieve it.

just not indexing content doesn't make that content not retrievable. I'd be very worried about this setting giving providers a false sense of security.

I think a control that is saying 'this is private content, don't index it' needs to also make that content not retrievable, or you're opening yourself up to very easily having providers improperly configure their permissions

LexLuthr commented 2 years ago

@willscott But denying retrieval would also deny end client to retrieve data. So they will have to go offline route to get their data from SPs. Wouldn't that create a more complex retrieval process?

willscott commented 2 years ago

there can be an over-ride for the specific client, but i guess the point is that content not indexed probably should be 'default-deny' for retrievals

honghaoq commented 2 years ago

@LexLuthr just to confirm, will you be following up with Lotus team on this requirement? On a side note, I wanted to tag your name for this task but looks like I dont have permission to do so, would be great if you can grant me permission to Lotus / gofilmarkets repo, thanks!

LexLuthr commented 2 years ago

@honghaoq https://github.com/filecoin-project/lotus/issues/8520 opened. I don't have perms to allow access. You can ask @jennijuju for access to those repos.

honghaoq commented 2 years ago

Closed as Duplicate https://github.com/filecoin-project/storetheindex/issues/728