search

filecoin-project / go-fil-markets

Shared Implementation of Storage and Retrieval Markets for Filecoin Node Implementations
Other
78 stars 59 forks source link

chore: update go-car dependency #709

Closed rvagg closed 2 years ago

rvagg commented 2 years ago

Ref: #639 Ref: https://github.com/ipld/go-car/issues/254

Backstory: once upon a time, go-car had a branch that was used here to act as a filestore, but that branch was never merged to master. Over time, go-fil-markets evolved away from that particular usage of go-car, eventually making it disappear entirely in favour of go-car/v2.

https://github.com/ipld/go-car/issues/254 documents attempts to get rid of this branch for good.

639 was a previous attempt to start removing this branch dependency here.

The last update to the go-car dependency here was #653 which just replaced the branch ref with the latest master, which worked fine because by that time the use of the filestore and need for zero==eof was redundant.

So now we're just moving to a tagged version here and ticking off an item back in https://github.com/ipld/go-car/issues/254 .

rvagg commented 2 years ago

TestRestartClient/ClientEventDealPublished is failing in CI and has been failing locally for me, even prior to this change, I don't have background on that and whether it's an expected flaky or not but I don't believe it's related to this.

hannahhoward commented 2 years ago

honestly don't worry about the test failure. though wow we should really get our circle updated so we can at least run tests. Eek!

hannahhoward commented 2 years ago

I'm just gonna invoke those sweet admin privileges and merge