search

filecoin-project / go-fil-markets

Shared Implementation of Storage and Retrieval Markets for Filecoin Node Implementations
Other
78 stars 59 forks source link

chore: extract Provider piece logic to separate file #750

Closed rvagg closed 1 year ago

rvagg commented 1 year ago

Based on feedback in https://github.com/filecoin-project/go-fil-markets/pull/749, which applied to #747 which was already merged.

also includes:

codecov-commenter commented 1 year ago

Codecov Report

Merging #750 (e051f00) into master (787c67b) will increase coverage by 0.38%. The diff coverage is 71.16%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/750/graphs/tree.svg?width=650&height=150&src=pr&token=bZaEF3LOTy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/750?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## master #750 +/- ## ========================================== + Coverage 57.59% 57.97% +0.38% ========================================== Files 65 66 +1 Lines 5474 5540 +66 ========================================== + Hits 3152 3211 +59 - Misses 1973 1979 +6 - Partials 349 350 +1 ``` | [Impacted Files](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/750?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [storagemarket/impl/provider\_environments.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/750/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-c3RvcmFnZW1hcmtldC9pbXBsL3Byb3ZpZGVyX2Vudmlyb25tZW50cy5nbw==) | `10.38% <0.00%> (+3.11%)` | :arrow_up: | | [storagemarket/impl/providerstates/provider\_fsm.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/750/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-c3RvcmFnZW1hcmtldC9pbXBsL3Byb3ZpZGVyc3RhdGVzL3Byb3ZpZGVyX2ZzbS5nbw==) | `74.60% <ø> (ø)` | | | [storagemarket/impl/provider.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/750/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-c3RvcmFnZW1hcmtldC9pbXBsL3Byb3ZpZGVyLmdv) | `26.50% <7.15%> (-0.13%)` | :arrow_down: | | [retrievalmarket/impl/provider\_environments.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/750/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L2ltcGwvcHJvdmlkZXJfZW52aXJvbm1lbnRzLmdv) | `66.67% <46.16%> (-2.38%)` | :arrow_down: | | [retrievalmarket/impl/provider.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/750/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L2ltcGwvcHJvdmlkZXIuZ28=) | `68.33% <66.67%> (-1.20%)` | :arrow_down: | | [retrievalmarket/impl/provider\_pieces.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/750/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L2ltcGwvcHJvdmlkZXJfcGllY2VzLmdv) | `83.19% <83.19%> (ø)` | |