filecoin-project / go-fil-markets

Shared Implementation of Storage and Retrieval Markets for Filecoin Node Implementations
Other
78 stars 59 forks source link

replace direct go-libp2p-core references with go-libp2p/core #777

Closed neelvirdy closed 1 year ago

neelvirdy commented 1 year ago

Fixes https://github.com/filecoin-project/go-fil-markets/issues/762

codecov-commenter commented 1 year ago

Codecov Report

Merging #777 (ded6810) into master (0fccfc9) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777/graphs/tree.svg?width=650&height=150&src=pr&token=bZaEF3LOTy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## master #777 +/- ## ======================================= Coverage 57.66% 57.66% ======================================= Files 66 66 Lines 5564 5564 ======================================= Hits 3208 3208 Misses 2013 2013 Partials 343 343 ``` | [Impacted Files](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [retrievalmarket/impl/client.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L2ltcGwvY2xpZW50Lmdv) | `71.05% <ø> (ø)` | | | [retrievalmarket/impl/clientstates/client\_states.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L2ltcGwvY2xpZW50c3RhdGVzL2NsaWVudF9zdGF0ZXMuZ28=) | `95.32% <ø> (ø)` | | | [retrievalmarket/impl/dtutils/dtutils.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L2ltcGwvZHR1dGlscy9kdHV0aWxzLmdv) | `81.20% <ø> (ø)` | | | [retrievalmarket/impl/provider\_environments.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L2ltcGwvcHJvdmlkZXJfZW52aXJvbm1lbnRzLmdv) | `66.67% <ø> (ø)` | | | [...market/impl/requestvalidation/requestvalidation.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L2ltcGwvcmVxdWVzdHZhbGlkYXRpb24vcmVxdWVzdHZhbGlkYXRpb24uZ28=) | `80.19% <ø> (ø)` | | | [retrievalmarket/migrations/migrations.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L21pZ3JhdGlvbnMvbWlncmF0aW9ucy5nbw==) | `68.46% <ø> (ø)` | | | [retrievalmarket/network/libp2p\_impl.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L25ldHdvcmsvbGlicDJwX2ltcGwuZ28=) | `84.91% <ø> (ø)` | | | [retrievalmarket/network/old\_query\_stream.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L25ldHdvcmsvb2xkX3F1ZXJ5X3N0cmVhbS5nbw==) | `77.15% <ø> (ø)` | | | [retrievalmarket/network/query\_stream.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L25ldHdvcmsvcXVlcnlfc3RyZWFtLmdv) | `60.00% <ø> (ø)` | | | [retrievalmarket/types.go](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cmV0cmlldmFsbWFya2V0L3R5cGVzLmdv) | `58.03% <ø> (ø)` | | | ... and [16 more](https://codecov.io/gh/filecoin-project/go-fil-markets/pull/777?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | |
neelvirdy commented 1 year ago

@hannahhoward @dirkmc could i get a review please?

neelvirdy commented 1 year ago

@marten-seemann i dont have perms to merge, mind granting me if you can or merging this?

neelvirdy commented 1 year ago

@hannahhoward @marten-seemann @dirkmc pinging again to get help with merging since i dont have perms

dirkmc commented 1 year ago

Making changes to go-fil-markets means we also need to make the same change in boost and lotus, then run a comprehensive test suite on both of those projects, so it's not a simple task. Is there an urgent need to make this change?

marten-seemann commented 1 year ago

Making changes to go-fil-markets means we also need to make the same change in boost and lotus, then run a comprehensive test suite on both of those projects, so it's not a simple task. Is there an urgent need to make this change?

This PR doesn't bump any versions, so it shouldn't have any side effects on other repos. Or am I missing something?

marten-seemann commented 1 year ago

@dirkmc @hannahhoward Is there anything else needed to get this PR merged?

dirkmc commented 1 year ago

@marten-seemann is the code at

"github.com/libp2p/go-libp2p-core/peer"

exactly the same as the code at

"github.com/libp2p/go-libp2p/core/peer"

?

Same question for protocol, network, etc

marten-seemann commented 1 year ago

Yes, we moved go-libp2p-core into go-libp2p a while ago.