filecoin-project / go-state-types

Primitive and low level types used in chain state and actor method parameters
Other
27 stars 37 forks source link

Remove incorrect invariants #188

Closed ZenGround0 closed 1 year ago

ZenGround0 commented 1 year ago

I'm still not 100% sure its right to remove these. They are definitely incorrect but invariant breaks of these forms are somewhat useful to see in the logs as they indicate particular edge cases that can be confirmed to not be part of the problem. I think it's probably better to remove them for cleanliness but ideally we'd try to find a way to assert something about the edge cases. Right now that looks either impossible or difficult hence this PR.