search

filecoin-project / go-state-types

Primitive and low level types used in chain state and actor method parameters
Other
24 stars 37 forks source link

feat: migration: sector deal ids index cached #210

Closed snissn closed 11 months ago

snissn commented 1 year ago
anorth commented 1 year ago

See #215, which should be integrated into this change.

snissn commented 1 year ago

Thanks @ZenGround0 I went through and resolved the easy notes, looks like remaining i have to:

  1. not construct the parent HAMT during the caching process and only at the end primarily because we will potentially keep data on miners that have been deleted between running the pre migration and the actual migration
  2. i'm using builtin.NewTree which is a wrapper around adt.Map and should just use adt.Map directly
  3. rename Lock used for hamt and make sure that it is initialized properly
  4. put market migration in it's own file to run after the migration ( might be need to get help w subtleties in this one)
ZenGround0 commented 1 year ago

The other thing is probably the most annoying change to filter out for inactive deal ids. Probably got lost among the rest since I left it in the review comment itself: https://github.com/filecoin-project/go-state-types/pull/210#pullrequestreview-1608361440

arajasek commented 11 months ago

Deferred to nv22.