search

filecoin-project / go-state-types

Primitive and low level types used in chain state and actor method parameters
Other
24 stars 37 forks source link

replace SimpleQaPower with flags #212

Closed LesnyRumcajs closed 1 year ago

LesnyRumcajs commented 1 year ago

See https://github.com/filecoin-project/builtin-actors/issues/1275 and https://github.com/filecoin-project/builtin-actors/pull/1395 (most notably @ZenGround0 comment)

In short, we want to have an easily extensible flags field for the SectorOnChainInfo instead of a field per flag, which is wasteful.

LesnyRumcajs commented 1 year ago

Hm, should the type of the flag be aligned with the type in bultin actors? I.e., both either 32 or 64 bits?

ZenGround0 commented 1 year ago

Hm, should the type of the flag be aligned with the type in bultin actors? I.e., both either 32 or 64 bits?

I gave it a try and cbor gen does not work with int32s. This should be fine for the long foreseeable future until with have 31 new flags. I'll file an issue.