search

filecoin-project / go-state-types

Primitive and low level types used in chain state and actor method parameters
Other
24 stars 37 forks source link

Add MovePartition params #218

Closed mb1896 closed 11 months ago

mb1896 commented 11 months ago

Ref story: https://github.com/filecoin-project/lotus/issues/11272

arajasek commented 11 months ago

This looks good to me, thank you! Let's wait until the actors code lands in order to land this PR, though -- in case it doesn't make it into v12, we'll have to add this to v13 actors only.

mb1896 commented 11 months ago

This looks good to me, thank you! Let's wait until the actors code lands in order to land this PR, though -- in case it doesn't make it into v12, we'll have to add this to v13 actors only.

Thanks. However, if we don't get to merge this one, how can we refer this repo in lotus so that my https://github.com/filecoin-project/lotus/pull/11290 PR can build?

arajasek commented 11 months ago

This looks good to me, thank you! Let's wait until the actors code lands in order to land this PR, though -- in case it doesn't make it into v12, we'll have to add this to v13 actors only.

Thanks. However, if we don't get to merge this one, how can we refer this repo in lotus so that my filecoin-project/lotus#11290 PR can build?

You can run go get https://github.com/filecoin-project/go-state-types@c7bfcda23a241f2c9a731ba27cc1d667c761407f && go mod tidy in your Lotus PR, and commit those changes. That'll let you point to your commit here.

We won't want that in the final release, but it's good enough to get CI building.