search

filecoin-project / go-state-types

Primitive and low level types used in chain state and actor method parameters
Other
24 stars 37 forks source link

change the value of duration from endEpoch-startEpoch to sectorExpiry-sectorActivation #237

Closed firesWu closed 1 month ago

firesWu commented 8 months ago

if the value endepoch - startepoch is used as the duration, the calculated initial collateral for real deal may be smaller than the actual value, leading to a failed execution of the provecommit msg execution.

rvagg commented 1 month ago

@firesWu we have a 👍 on this from the miner code experts, thanks for catching it. Would you mind rebasing and switching your v12 change to v14?

rvagg commented 1 month ago

It was easy enough to do in a new PR @ https://github.com/filecoin-project/go-state-types/pull/291

rvagg commented 1 month ago

merged as #291, thanks @firesWu