search

filecoin-project / go-state-types

Primitive and low level types used in chain state and actor method parameters
Other
26 stars 37 forks source link

Wrong type of SectorAllocationClaim in Verifiedregistry #241

Closed Terryhung closed 4 months ago

Terryhung commented 8 months ago

There is a discrepancy between the schema SectorAllocationClaim in builtin-actors v12 and the schema SectorAllocationClaim in go-state-types v12.

Therefore, there is a mismatch between the SectorAllocationClaim in go-state-types v12 and the actual data.

The new schema should be this:

pub struct SectorAllocationClaims {
    pub sector: SectorNumber,
    pub expiry: ChainEpoch,
    pub claims: Vec<AllocationClaim>,
}

Then I found it did not be fixed in v13, is there any plan for fix it?

Thanks!

Stebalien commented 8 months ago

If you make a PR, I'll review it.

LuisCherry commented 5 months ago

Excuse me, may I ask when this issue can be fixed

rvagg commented 5 months ago

to be fair to OP, changing these while making cbor-gen happy in the interim isn't exactly easy, here's a fix: https://github.com/filecoin-project/go-state-types/pull/262