search

filecoin-project / go-state-types

Primitive and low level types used in chain state and actor method parameters
Other
25 stars 35 forks source link

Add tooling so releasing doesn't happen out of code review #275

Closed BigLep closed 4 days ago

BigLep commented 1 month ago

Done Criteria

The release steps outlined in https://github.com/filecoin-project/go-state-types/pull/273 can be followed without requiring manual clicking in the GitHub UI. Instead, releases should occur as a result of an approved PR.

Why Important

The release process in https://github.com/filecoin-project/go-state-types/pull/273 doesn't have any peer review. Mistakes can get made. Mistagging has happened in the past and can't be reverted. This is usually fixed by just doing another release, but this adds unnecessary confusion.

User/Customer

Maintainers

Notes

  1. @BigLep knows Lotus Maintainers had understandably made tagging mistakes in the past (it's inevitable). I don't recall the specific instances off hand though. I believe though that this is what helped fuel some of the "version.json" work for "unified CI".
  2. @BigLep's knowlege about the permanence of git tags may be out of date.
BigLep commented 1 month ago

2024-06-18: per triage conversation, mistakes here aren't as significant given go-state-types is in the middle layer. The concern on adding a review step is that it will increase the calendar time for a release.

BigLep commented 4 days ago

Closed by https://github.com/filecoin-project/go-state-types/pull/283