search

filecoin-project / go-state-types

Primitive and low level types used in chain state and actor method parameters
Other
25 stars 35 forks source link

chore: include manifest & proof in `make gen`; add extra proof types #288

Closed rvagg closed 1 week ago

rvagg commented 2 weeks ago

The manifest line in Makefile is included in #283 because it's needed to get past new linting. But proof is not included there and I wanted to serialise a couple of the Aggregate types in there for debugging but they don't yet have cbor-gen additions. We don't strictly need these for communication between lotus and actors, but they are handy to have for debugging!

aarshkshah1992 commented 2 weeks ago

@rvagg This looks straight forward. Please merge when ready.

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 552 lines in your changes missing coverage. Please review.

Project coverage is 3.57%. Comparing base (9d1dc56) to head (07a2695).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/288/graphs/tree.svg?width=650&height=150&src=pr&token=HKKDOH9D3X&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## master #288 +/- ## ========================================= - Coverage 3.58% 3.57% -0.02% ========================================= Files 520 520 Lines 96648 96959 +311 ========================================= Hits 3468 3468 - Misses 91829 92140 +311 Partials 1351 1351 ``` | [Files](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/288?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [proof/gen/gen.go](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/288?src=pr&el=tree&filepath=proof%2Fgen%2Fgen.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cHJvb2YvZ2VuL2dlbi5nbw==) | `0.00% <0.00%> (ø)` | | | [proof/cbor\_gen.go](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/288?src=pr&el=tree&filepath=proof%2Fcbor_gen.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cHJvb2YvY2Jvcl9nZW4uZ28=) | `0.00% <0.00%> (ø)` | |