search

filecoin-project / go-state-types

Primitive and low level types used in chain state and actor method parameters
Other
27 stars 37 forks source link

fix(miner)!: remove DEAL_WEIGHT_MULTIPLIER and its input to QAP calc #308

Closed rvagg closed 1 month ago

rvagg commented 2 months ago

Ref: https://github.com/filecoin-project/builtin-actors/issues/1573 Ref: https://github.com/filecoin-project/builtin-actors/pull/1574

Test copied across from Rust.

This will have implications for Lotus because of the breaking API change, it'd probably be worth figuring out how much pain that is before merging this.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 3.54%. Comparing base (6e096a2) to head (d1961e0).

Files with missing lines Patch % Lines
builtin/v15/miner/policy.go 50.00% 3 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/308/graphs/tree.svg?width=650&height=150&src=pr&token=HKKDOH9D3X&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## master #308 +/- ## ========================================== + Coverage 3.53% 3.54% +0.01% ========================================== Files 592 592 Lines 110759 110757 -2 ========================================== + Hits 3915 3931 +16 + Misses 105311 105293 -18 Partials 1533 1533 ``` | [Files with missing lines](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/308?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [builtin/network.go](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/308?src=pr&el=tree&filepath=builtin%2Fnetwork.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-YnVpbHRpbi9uZXR3b3JrLmdv) | `33.33% <ø> (ø)` | | | [builtin/v15/miner/policy.go](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/308?src=pr&el=tree&filepath=builtin%2Fv15%2Fminer%2Fpolicy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-YnVpbHRpbi92MTUvbWluZXIvcG9saWN5Lmdv) | `41.17% <50.00%> (+41.17%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-state-types/pull/308/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)
Stebalien commented 1 month ago

Given that this doesn't actually change the power calculus, the breaking change shouldn't be a huge issue (no need to abstract over different versions, we can just change it everywhere).