search

filecoin-project / lassie

A minimal universal retrieval client library for IPFS and Filecoin
Other
111 stars 17 forks source link

feat: --duplicates on CLI to putput duplicate blocks #444

Closed rvagg closed 1 year ago

rvagg commented 1 year ago

Closes: https://github.com/filecoin-project/lassie/issues/335

draft because something's wrong with duplicates output from this; noticeable with nontrivial numbers of duplicate blocks and I'm not sure if this applies just to this new feature or if it also applies to the daemon

codecov-commenter commented 1 year ago

Codecov Report

Merging #444 (b68d383) into main (1d83c9a) will decrease coverage by 0.39%. The diff coverage is 36.20%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/lassie/pull/444/graphs/tree.svg?width=650&height=150&src=pr&token=0ELGTPSK3J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/lassie/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #444 +/- ## ========================================== - Coverage 75.91% 75.53% -0.39% ========================================== Files 86 86 Lines 6586 6622 +36 ========================================== + Hits 5000 5002 +2 - Misses 1304 1335 +31 - Partials 282 285 +3 ``` | [Files](https://app.codecov.io/gh/filecoin-project/lassie/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [pkg/storage/duplicateaddercar.go](https://app.codecov.io/gh/filecoin-project/lassie/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-cGtnL3N0b3JhZ2UvZHVwbGljYXRlYWRkZXJjYXIuZ28=) | `86.01% <52.17%> (-6.85%)` | :arrow_down: | | [cmd/lassie/fetch.go](https://app.codecov.io/gh/filecoin-project/lassie/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-Y21kL2xhc3NpZS9mZXRjaC5nbw==) | `33.06% <25.71%> (-0.57%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/lassie/pull/444/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)