search

filecoin-project / lassie

A minimal universal retrieval client library for IPFS and Filecoin
Other
108 stars 17 forks source link

Add gateway conformance test workflow #452

Open hannahhoward opened 11 months ago

hannahhoward commented 11 months ago

Since the official test of trustless gateway lives in ipfs/gateway-conformance, adding the test here.

Still working on this, especially cause we're not currently passing.

codecov-commenter commented 11 months ago

Codecov Report

Merging #452 (2c7fb51) into main (2cf1121) will increase coverage by 0.11%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/lassie/pull/452/graphs/tree.svg?width=650&height=150&src=pr&token=0ELGTPSK3J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/lassie/pull/452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #452 +/- ## ========================================== + Coverage 75.73% 75.85% +0.11% ========================================== Files 87 87 Lines 6677 6677 ========================================== + Hits 5057 5065 +8 + Misses 1335 1332 -3 + Partials 285 280 -5 ``` [see 7 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/lassie/pull/452/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)
rvagg commented 11 months ago

If you end up changing the way that trustless-utils handles ranges, you may find that the e2e test in here fails; because frisbii is using the same logic to serve that data, so it's a matter of making the changes flow through the set of things, frisbii first and then lassie. i.e. e2e failing here isn't necessarily a problem and should be easily fixable if we agree that the change is correct and should be bubbled up through the stack.