filecoin-project / lassie

A minimal universal retrieval client library for IPFS and Filecoin
Other
111 stars 17 forks source link

deps: downgrade boxo to working commit #460

Closed rvagg closed 6 months ago

rvagg commented 1 year ago

Ref: https://github.com/filecoin-project/lassie/issues/459

I think this is probably not a big deal because the only direct use of storetheindex we have here is to pull in the e2e test runner (and when running the e2e test it grabs HEAD). Not sure if there's anything that transitives are using that might be important to have this upgrade for though. @gammazero ?

rvagg commented 1 year ago

ugh, this doesn't work because of the peer.ID#Pretty removal in libp2p

added another commit to downgrade more but it's ended up as basically a revert of https://github.com/filecoin-project/lassie/pull/456, which isn't ideal

codecov-commenter commented 1 year ago

Codecov Report

Merging #460 (fa00791) into main (56a0b1d) will decrease coverage by 0.11%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/lassie/pull/460/graphs/tree.svg?width=650&height=150&src=pr&token=0ELGTPSK3J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/lassie/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #460 +/- ## ========================================== - Coverage 75.72% 75.61% -0.11% ========================================== Files 87 87 Lines 6657 6657 ========================================== - Hits 5041 5034 -7 - Misses 1335 1338 +3 - Partials 281 285 +4 ``` [see 10 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/lassie/pull/460/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)
gammazero commented 1 year ago

It would be nice to just fix bitswap. Added my voice to the original issue here

gammazero commented 6 months ago

This PR is no longer needed.

Using new boxo branch (feat/lassie-fork-boxo-v0.19.0) with bitswap patch.