filecoin-project / lotus-infra

1 stars 0 forks source link

Simplify reset CI parameters #1618

Closed masih closed 2 months ago

masih commented 2 months ago

Infer "deploy network" from a simple network name and use consistent input naming across jobs.

Fixes #1611

masih commented 2 months ago

Dry-run of changes here worked as expected, failing with host being unavailable.

rjan90 commented 2 months ago

I made the instances available, but we are now encountering: Group fc does not exist failures in when trying to do the Dry-run: https://github.com/filecoin-project/lotus-infra/actions/runs/10733831631/job/29767872938.

TASK [common : Ensure login user is added group] *******************************
fatal: [preminer-1.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [scratch-0.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [bootstrap-0.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [bootstrap-1.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [toolshed-0.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [preminer-2.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [preminer-0.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
fatal: [toolshed-1.butterfly.fildev.network]: FAILED! => {"changed": false, "msg": "Group fc does not exist"}
masih commented 2 months ago

@rjan90 these are "resumed" instances, not stood up from scratch. Correct?

rjan90 commented 2 months ago

They are ”stood up from scratch” I think. At least I had to run terraform apply because the recorded where out of date, and in that process it terminated the old instances and created new instances.

masih commented 2 months ago

Do you still have the terraform apply logs? If so, I'd like to know how many resources updated vs created vs destroyed.

rjan90 commented 2 months ago

Sorry that I derailed the PR a bit with an unrelated error. But the changes here looks good to me, and looks and behaves as expected, making running the reset a little less confusing

Screenshot 2024-09-06 at 13 51 43
masih commented 2 months ago

No worries. THe issue indeed seems unrelated. Looking into it.