filecoin-project / lotus-infra

1 stars 0 forks source link

Use the all-in-one lotus dockerfile for simpler/faster build #1626

Closed masih closed 2 months ago

masih commented 2 months ago

Use the default dockerfile already offered by lotus repo to build the binaries. This speeds up the build in this repo by about 5X.

Remove all references to the old dockerfiles in the repo and update scripts as needed.

While at it, remove all redundant and unused scripts that relate to building lotus.

masih commented 2 months ago

Proof that it works, ran on fresh ec2 instances: https://github.com/filecoin-project/lotus-infra/actions/runs/10794509096/job/29938954343

masih commented 2 months ago

..and reset of a network that is already up with cached binaries now takes ~10m: https://github.com/filecoin-project/lotus-infra/actions/runs/10795108618

masih commented 2 months ago

I have now terminated the butterflynet EC2 instances. If you wish to reset the network via CI jobs you need to run terraform apply for butterflynet network first.

masih commented 2 months ago

This all seems reasonable, but I also don't know the reasons behind many of these scripts.

That's part of the problem, in that I cannot find where any of the scripts I remove are used. My take is that they are all leftover from the long journey this repo has been through.

I have no concerns about removing them, because they are clearly used/redundant, and we can always fish them back out of version control system.