filecoin-project / lotus

Reference implementation of the Filecoin protocol, written in Go
https://lotus.filecoin.io/
Other
2.81k stars 1.24k forks source link

Calibration network genesis should have a faucet account for tokens and datacap #12165

Open aarshkshah1992 opened 1 week ago

aarshkshah1992 commented 1 week ago

Checklist

Lotus component

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

Caliberation network genesis should have a faucet account for tokens and datacap.

Describe the solution you'd like

Only migrate the f090 Actor to a keyless Actor if it is a multisig.

Describe alternatives you've considered

No response

Additional context

No response

BigLep commented 1 week ago

Related butterfly issue (https://github.com/filecoin-project/lotus/issues/12160 ), which links to Slack thread with more info.

f8-ptrk commented 4 days ago

isn't the FIPs implementation wrong if this gets done on a non multisig f090 in the first place?

the fip explicitly says that it only applies to a multisig f090 actor.

Convert f090 actor type from a multisig to account type

this should not need network specific implementations.

The new account actor should be keyless, like f099

this branch should never been reached if its not a multisig f090

aarshkshah1992 commented 3 days ago

@f8-ptrk

The implementation now ensures that f090 is a multisig before doing the migration. Please see https://github.com/filecoin-project/go-state-types/pull/281.

rjan90 commented 3 days ago

We will keep the ticket open until the Calibration upgrade has happened.

f8-ptrk commented 3 days ago

@aarshkshah1992 my worries were non public networks here that would have needed adjustment too if this would have been solved via a calib/butterfly specific fix