filecoin-project / lotus

Reference implementation of the Filecoin protocol, written in Go
https://lotus.filecoin.io/
Other
2.85k stars 1.27k forks source link

ChainIndexer: GetMsgInfo should return ErrNotFound when not found #12674

Closed rvagg closed 5 days ago

rvagg commented 2 weeks ago
2024-11-06T21:13:14.735+1100    WARN    statemgr        stmgr/searchwait.go:175 error searching message index: error looking up message in index: sql: no rows in result set

Lots of this kind of thing in the logs, but it shouldn't be logged: https://github.com/filecoin-project/lotus/blob/8865a9d0931bbb6167944b5a4cd6867290aabea2/chain/stmgr/searchwait.go#L171-L176

GetMsgInfo should return an ErrNotFound when there are no rows, here: https://github.com/filecoin-project/lotus/blob/8865a9d0931bbb6167944b5a4cd6867290aabea2/chain/index/read.go#L51-L54

Needs tests as well.