filecoin-project / lotus

Reference implementation of the Filecoin protocol, written in Go
https://lotus.filecoin.io/
Other
2.85k stars 1.27k forks source link

feat: nv25 network skeleton #12707

Closed kamuik16 closed 1 day ago

kamuik16 commented 6 days ago

Related Issues

Closes #12686

Checklist

Before you mark the PR ready for review, please make sure that:

rjan90 commented 3 days ago

Doing a test run in a devnet:

Network version at the start of the devnet:

lotus state actor-cids
Network Version: 24
Actor Version: 15
Manifest CID: bafy2bzacedlusqjwf7chvl2ve2fum5noyqrtjzcrzkhpbzpkg7puiru7dj4ug
----

I can see that the pre-migration happens on my node, as well as the actual migration at epoch 200:

2024-11-22T13:05:33.869+0100    WARN    statemgr        stmgr/forks.go:202      STARTING migration      {"height": "200", "from": "bafy2bzacebym7hpxfnj4ibbrw5dmk2ifcld4c2qykfczg5owvjueyqy2cxu4s"}
2024-11-22T13:05:33.869+0100    INFO    bundle  bundle/bundle.go:60     manifest cid: bafy2bzacedlusqjwf7chvl2ve2fum5noyqrtjzcrzkhpbzpkg7puiru7dj4ug
------
2024-11-22T13:05:33.869+0100    INFO    fil-consensus   filcns/upgrades.go:3001 All 17 done after 132.917µs (127899/s)
2024-11-22T13:05:33.869+0100    WARN    statemgr        stmgr/forks.go:211      COMPLETED migration     {"height": "200", "from": "bafy2bzacebym7hpxfnj4ibbrw5dmk2ifcld4c2qykfczg5owvjueyqy2cxu4s", "to": "bafy2bzacebym7hpxfnj4ibbrw5dmk2ifcld4c2qykfczg5owvjueyqy2cxu4s", "duration": 0.000383541}

See that we switch actors-bundle version and network version:

lotus state actor-cids
Network Version: 25
Actor Version: 16
Manifest CID: bafy2bzacedlusqjwf7chvl2ve2fum5noyqrtjzcrzkhpbzpkg7puiru7dj4ug

And the network is able to progress after upgrade epoch:

228: (Nov 22 13:07:20) [ bafy2bzacecl4id5ktip33yrbdmy23kxpdqbmopefhfbkihdtnw4enkc54327y: t01000, ]
229: (Nov 22 13:07:24) [ bafy2bzacecynlqv5bqrsgjrnjhrj233j553vru5g3pjvwyofvgmo7mpgwk7re: t01000, ]
230: (Nov 22 13:07:28) [ bafy2bzacebex5hvdhzhjnf4vtu6dbnom7vmvuxcalae6kzlcyap2kxaeyn26o: t01000, ]
231: (Nov 22 13:07:32) [ bafy2bzacedkwqxoutgcbpnz4wb7azlpbsgh2ptfghhcb7mnrmnkeolxngnsfq: t01000, ]
rvagg commented 1 day ago
kamuik16 commented 1 day ago
  • lint & migration test failure can be fixed with my suggestion - var instead of const for that one
  • gateway test failure is a known flaky
  • eth_transactions test failure is odd, but very likely unrelated to this - let's see how it goes when a change is pushed here and it reruns.

the var instead of const created some kind of a havoc in the CI.

rvagg commented 1 day ago

There's something funky going on with your actors gen, there's a signature mismatch that's unrelated to the tuktuk upgrade epoch. Can you run make gen again and see if that changes anything locally?

kamuik16 commented 1 day ago

There's something funky going on with your actors gen, there's a signature mismatch that's unrelated to the tuktuk upgrade epoch. Can you run make gen again and see if that changes anything locally?

It didn't

kamuik16 commented 1 day ago

There's something funky going on with your actors gen, there's a signature mismatch that's unrelated to the tuktuk upgrade epoch. Can you run make gen again and see if that changes anything locally?

But solved it somehow.

kamuik16 commented 1 day ago

@rjan90, @rvagg the CI is green, do you want to run the devnet sim again or is it good to go?

rjan90 commented 1 day ago

@rjan90, @rvagg the CI is green, do you want to run the devnet sim again or is it good to go?

I will re-run just for sanity

rjan90 commented 1 day ago

Confirming that the sanity check of re-running a devnet with the final changes was good.

Seeing the migration complete:

2024-11-25T09:42:20.954+0100    WARN    statemgr        stmgr/forks.go:211      COMPLETED migration     {"height": "200", "from": "bafy2bzacebxw32mnbrbt6clzdncha2uxwzztkw4jrxebu4ddf3r7e2ktytumq", "to": "bafy2bzacebxw32mnbrbt6clzdncha2uxwzztkw4jrxebu4ddf3r7e2ktytumq", "duration": 0.000398791}

And the chain progresses after the nv25 upgrade:

222: (Nov 25 09:43:42) [ bafy2bzaceczz2xxnl6kibjzybnlex473ccfi5qsqvwgs6wayhru2a5l3uzasg: t01000, ]
223: (Nov 25 09:43:46) [ bafy2bzaced76rk4m22qnqhjdmqbsyt4eh3vversdc3qvwaqxaeido77pviqw2: t01000, ]
224: (Nov 25 09:43:50) [ bafy2bzacedxyhv5zwnefcxg73c5yb52het56qkrdgqpscfffy7sbkcxduh5ge: t01000, ]
225: (Nov 25 09:43:54) [ bafy2bzacebinngor2nykaxpcjn44vzx4j4tj3hwtjo2xtfvn6ixjzd4i44waq: t01000, ]
226: (Nov 25 09:43:58) [ bafy2bzacecoznvx4tx4m7piirovs56yoescsmvytfmo7jbetqx46l2jf3zqjo: t01000, ]