search

filecoin-project / lotus

Reference implementation of the Filecoin protocol, written in Go
https://lotus.filecoin.io/
Other
2.85k stars 1.27k forks source link

Disable payment channel manager by default #12718

Open rvagg opened 1 day ago

rvagg commented 1 day ago

On node startup, even for a light node, the payment channel manager starts up and watches the chain for paych-related messages to react to. Payment channels get minimal (to no) use currently on mainnet so we should be safe to introduce a configuration option to disable the payment channel manager and turn it on by default.

See https://github.com/filecoin-project/lotus/blob/0d1d7c29c21b41de79be67ef4dcedb4f973bf7c2/node/builder_chain.go#L120-L126

f8-ptrk commented 1 day ago

you mean turn it off by default?

[edit]

its not quite clear what you want as an outcome - it seems its already enabled by default, is it? turning it off by default and intro an option to enable it would make sense

rvagg commented 23 hours ago

Yeah, sorry, bad wording - turn it off by default, stop it humming in the background.

A few of us are also discussing how we might trim the code down around the paych functionality, removing most, or even all of it from Lotus.