Retry failed ProveCommitSector

AthenaPoolOfficial commented 3 years ago

Checklist

[X] This is not a security-related bug/issue. If it is, please follow please follow the security policy.
[X] This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
[X] This is not a new feature request. If it is, please file a feature request instead.
[X] This is not an enhancement request. If it is, please file a improvement suggestion instead.
[X] I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
[X] I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
[X] I did not make any code changes to lotus.

Lotus component

[ ] lotus daemon - chain sync
[ ] lotus miner - mining and block production
[X] lotus miner/worker - sealing
[ ] lotus miner - proving(WindowPoSt)
[ ] lotus miner/market - storage deal
[ ] lotus miner/market - retrieval deal
[ ] lotus miner/market - data transfer
[ ] lotus client
[ ] lotus JSON-RPC API
[ ] lotus message management (mpool)
[ ] Other

Lotus Version

Daemon: 1.12.0
Miner: 1.12.0

Describe the Bug

Specifications： It leads sectors to executing Committing again that lotus returns the error of 'failed to submit proof for bulk verification error (RetCode = 32) ' when storage providers submit ProveCommitSector. We suggest that ProveCommitSector should be resubmitted when this error occurs. Code logs: The handleCommitFailed function in extern/storage-sealing/states_failed.go misses the processing with retcode = 32 when it estimates the return value of mw.Receipt.ExitCode.

Logging Information

failed to submit proof for bulk verification (RetCode=32)

Repo Steps

Run '...'
Do '...'
See error '...' ...

AthenaPoolOfficial commented 2 years ago

@jennijuju

arajasek commented 2 years ago

IIRC, we already have retries for methods like PreComiitSectorBatch and ProveCommitAggregate. If we don't have a retry mechanism for ProveCommitSector we should definitely add it.

jennijuju commented 2 years ago

the solution of this might be helpful to https://github.com/filecoin-project/lotus/issues/8244 as well.

filecoin-project / lotus