search

filecoin-project / lotus

Reference implementation of the Filecoin protocol, written in Go
https://lotus.filecoin.io/
Other
2.82k stars 1.25k forks source link

CI step printing dependency diff #8170

Open magik6k opened 2 years ago

magik6k commented 2 years ago

In dependency-updating PRs it would be really convenient to have a CI step which would print diffs of code in dependencies - so it's easy to see changes in deps.

This can be done with something like:

git clone -b [base branch] https://github.com/filecoin-project/lotus a
git clone -b [target branch] https://github.com/filecoin-project/lotus b
cd a
make buildall
go mod vendor
cd ../b
make buildall
go mod vendor
cd ..

diff -r --color a/vendor b/vendor

Just need to make this into a CircleCI step.

Example output comparing current master with deps/update-libp2p: https://gist.github.com/magik6k/c4013988d8230aadc1de1d9d4a9809b5

AleemRehman commented 2 years ago

@magik6k / @jennijuju can have a look at this?

jennijuju commented 2 years ago

@magik6k / @jennijuju can have a look at this?

Hi! Do you mean you wanna work on this one?

witnsby commented 1 year ago

Hello @jennijuju, can I be assigned to it?