Open shotcollin opened 2 years ago
Hey @shotcollin!
Thanks for the detailed issue-report. I will try to reproduce it on a newer version as I know some kvlog / error-loops events have been fixed in the upcoming v1.15.1 release, see this PR: #8338.
Many apologies @shotcollin , the discussion was locked in error but is now open again for comment.
Many apologies @shotcollin , the discussion was locked in error but is now open again for comment.
No worries @TippyFlitsUK , I thought that was probably what happened, but then couldn't find a way to send a dm so figured this was the next best thing...
Discussed in https://github.com/filecoin-project/lotus/discussions/8399
This issue was turned into a discussion, but the discussion was immediately locked and didn't allow any comment, update, further discussion, etc. So I apologize for turning this back into an issue, but that was the only way to add this annotation:
I attempted to make the original issue clear in that it wasn't referring to my specific config error that caused the massive increase in log size, but rather the fact that any config error in general could (presumably) have a similar effect, which is writing a new log file line once every millisecond. In my case the line was a (640-character) warning, which would have caused the log to increase at a rate over 2 GiB per hour, and over 51 GiB per day (if my calculations are correct).
What makes this problematic and not simply an issue of operator error is that the log file increase didn't occur until hours after the config file was changed, meaning a SP could make a config change, assume the miner was running fine since no immediate errors or warnings were reported, then encounter a problem potentially hours later in which, if log files are being written to the OS drive, warning messages could cause significant log file expansion. This growth could be fast enough to fill up a drive before
logrotate
or some other automatic mitigation kicks in.That being said, please of course feel free to turn this back into a discussion if more appropriate there.