filecoin-project / lotus

Reference implementation of the Filecoin protocol, written in Go
https://lotus.filecoin.io/
Other
2.85k stars 1.27k forks source link

Butterfly has wrong genesis in v1.15.X releases #8647

Closed travisperson closed 2 years ago

travisperson commented 2 years ago

Checklist

Lotus component

Lotus Version

v1.15.X

Describe the Bug

A genesis committed from January 7th was some how released into v1.15.0

The genesis is from a commit a98ca86a4540cf71c6a6b4a14a94aa0b9b12bafd on Jan 7th

Logging Information

v1.12.0 8873e3f708621cb2e59913b1a270a6075c680272c6bb181caef78e8cf1533bd2    755b44aa1dfdcaf4c1d9c550e356bdaddb3990d4bad84d4fe9bafe420c66e188
v1.13.0 8873e3f708621cb2e59913b1a270a6075c680272c6bb181caef78e8cf1533bd2    755b44aa1dfdcaf4c1d9c550e356bdaddb3990d4bad84d4fe9bafe420c66e188
v1.13.1 8873e3f708621cb2e59913b1a270a6075c680272c6bb181caef78e8cf1533bd2    755b44aa1dfdcaf4c1d9c550e356bdaddb3990d4bad84d4fe9bafe420c66e188
v1.13.2 8873e3f708621cb2e59913b1a270a6075c680272c6bb181caef78e8cf1533bd2    755b44aa1dfdcaf4c1d9c550e356bdaddb3990d4bad84d4fe9bafe420c66e188
v1.14.0 7c1118307657229e50438495d099d1182d3b913c5ea5a23e1cca948fb744fb0f    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
v1.14.1 7c1118307657229e50438495d099d1182d3b913c5ea5a23e1cca948fb744fb0f    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
v1.14.2 7c1118307657229e50438495d099d1182d3b913c5ea5a23e1cca948fb744fb0f    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
v1.14.3 7c1118307657229e50438495d099d1182d3b913c5ea5a23e1cca948fb744fb0f    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
v1.14.4 7c1118307657229e50438495d099d1182d3b913c5ea5a23e1cca948fb744fb0f    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
v1.15.0 5d843d27da587fdde0194a25f5274b32988a86e454bdc4838d09f961339222aa    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
v1.15.1 5d843d27da587fdde0194a25f5274b32988a86e454bdc4838d09f961339222aa    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
v1.15.2 5d843d27da587fdde0194a25f5274b32988a86e454bdc4838d09f961339222aa    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
release/v1.15.3 5d843d27da587fdde0194a25f5274b32988a86e454bdc4838d09f961339222aa    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
master  5d843d27da587fdde0194a25f5274b32988a86e454bdc4838d09f961339222aa    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8

Repo Steps

refs=(
  v1.12.0
  v1.13.0
  v1.13.1
  v1.13.2
  v1.14.0
  v1.14.1
  v1.14.2
  v1.14.3
  v1.14.4
  v1.15.0
  v1.15.1
  v1.15.2
  release/v1.15.3
  master
)

digest() {
  case "$(uname -s)" in
    Linux)
      sha256sum $1
      ;;
    Darwin)
      shasum -a 256 $1
      ;;
  esac
}

for r in "${refs[@]}"; do
  git checkout $r > /dev/null 2>&1
  hg=$(digest ./build/genesis/butterflynet.car  | awk '{print $1}')
  hb=$(digest ./build/bootstrap/butterflynet.pi | awk '{print $1}')
  echo -e "$r\t$hg\t$hb"
done
travisperson commented 2 years ago

I believe this is a bit of a chicken & egg issue. When we reset the butterfly network it generally happens prior to a release being cut. In this case, we reset the network using v1.14.0-rc5, https://github.com/filecoin-project/lotus/pull/8032 (https://github.com/filecoin-project/lotus/pull/8032/commits/9b68174231737a023344adc76ddf243e925932fc).

When master merged into v1.15.0, we overwrote this change.

v1.14.0-rc1 5d843d27da587fdde0194a25f5274b32988a86e454bdc4838d09f961339222aa    c24f629346ec27cf29edc9211d448dd5efe89bad5c8709795f9486ed45263ed9
v1.14.0-rc4 5d843d27da587fdde0194a25f5274b32988a86e454bdc4838d09f961339222aa    c24f629346ec27cf29edc9211d448dd5efe89bad5c8709795f9486ed45263ed9
v1.14.0-rc5 5d843d27da587fdde0194a25f5274b32988a86e454bdc4838d09f961339222aa    c24f629346ec27cf29edc9211d448dd5efe89bad5c8709795f9486ed45263ed9
v1.14.0-rc6 7c1118307657229e50438495d099d1182d3b913c5ea5a23e1cca948fb744fb0f    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
v1.14.0-rc7 7c1118307657229e50438495d099d1182d3b913c5ea5a23e1cca948fb744fb0f    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
v1.14.0 7c1118307657229e50438495d099d1182d3b913c5ea5a23e1cca948fb744fb0f    9518bc53c5575cc33427e3b8b71b8ac7a89a2c8779b4bb6585f3288eaa66bba8
travisperson commented 2 years ago

Some further investigate into this issue v1.14.0 was merged back into master. This should have updated master to use the 7c1118...44fb0f genesis. However, it doesn't appear to be a file in PR https://github.com/filecoin-project/lotus/pull/8053.

jennijuju commented 2 years ago

closed by #8708