search

filecoin-project / notary-governance

113 stars 55 forks source link

Modification: 4th round Large Dataset Notary Multisig Signers v3.1 #835

Closed galen-mcandrew closed 3 weeks ago

galen-mcandrew commented 1 year ago

Issue Description

To modify an existing multisig (such as adding and removing signers) requires each change to come with a proposal message and an approval. Since we are adding many new notaries to the signer pool with the 4th round of elections, this would require a massive lift. It is significantly easier to just create a new multisig address on chain, with the new set of signers, and award that multisig with DataCap, then point all the tooling and dashboards to the new address.

Impact

This will not impact other programs, like E-Fil+ or the direct allocation pathway. Those will require other changes, out of scope of this specific modification.

Proposed Solution(s)

We will refer to this as the LDN v3.1 address, since it is still functionally the same process: approved notaries, admins for maintenance, threshold of 2, and ongoing top-up from RKH based on 4 week DataCap outflow to LDNs.

Address: f02049625 Robust Address: f2yk6skf7mpk5mkp3bk5qyy5pmxgic6hfp55z2wcq https://filfox.info/en/address/f2yk6skf7mpk5mkp3bk5qyy5pmxgic6hfp55z2wcq

Signers

Admins: These are not intended to award DataCap to clients. These addresses are intended for governance team to make changes to signers as necessary, such as removal or updating with new address.

Notary Signers: Please note: these notaries should not add/remove/edit the signers on this multisig. Changes (such as a new Ledger address) should be processed through the Governance Team to check for disclosures and diligence.

Timeline

New address created and awarded DataCap from RKH by Feb 24. Dashboards and Registry tooling notified of new v3.1 address Feb 24. All NEW LDN allocation requests (first and subsequent) initiated from Feb 24 will be requested from v3.1 address. All open allocation requests that have one proposal (labeled "startSign") prior to Feb 24 will still pull from v3.0 address. This is necessary to not abandon the first notary proposal transaction. This affects ~44 issues. All open allocation requests WITHOUT a proposal prior to Feb 24 will be updated to point to new notary v3.1 address. This affects ~364 issues.

Technical dependencies

Dashboards and registry tooling should update to track new address.

End of POC checkpoint (if applicable)

Risks and mitigations

Related Issues

This is similar to the LDN v3 issue, with the new set of notaries: https://github.com/filecoin-project/notary-governance/issues/509

Joyologist commented 1 year ago

@galen-mcandrew Hi Galen, I'm Joyologist from Tokencan. I'm afraid our address posted in the Notary Signers might be wrong. Please check our issue #746. Please let me know if there's anything you need. Thanks a lot!

galen-mcandrew commented 1 year ago

@galen-mcandrew Hi Galen, I'm Joyologist from Tokencan. I'm afraid our address posted in the Notary Signers might be wrong. Please check our issue #746. Please let me know if there's anything you need. Thanks a lot!

Thanks! Edited parent comment, updated our tracking spreadsheet, and added to v3.1 msig f02049625

zcfil commented 1 year ago

@galen-mcandrew Hi Galen, I'm from ZC LABS. The wallet address we announced here needs to be modified. This is not the hardware wallet we use now. We have previously submitted the change record in the disclosure form and modified it in the #643 application header, but it seems that there is no change here. Please update it for me, thank you!

kyokaki commented 1 year ago

@galen-mcandrew Hi Galen, this is from Interstellar Storage（ShenZhen). I checked that we are not on the list, and we already received the ledger verified message at 768. Please let me know if there are any problems here, thank you so much!

Trevor-K-Smith commented 1 year ago

@Kevin-FF-USA Hey Kevin, i do not seem my name above. Thanks

-- Ghost Byte

NiwanDao commented 1 year ago

I signed a LDN created later than Feb 24, but it still pull from LDN V3.0 address. Check my msg on LDN #1696 https://filfox.info/en/message/bafy2bzacebyc4j6gmwtuucw2evbe2eqkoziilzbhz6kbcosty4j2bq4wqrxbi

galen-mcandrew commented 1 year ago

@zcfil & @kyokaki , will work on adding and updating.

@Trevor-K-Smith It appears we are missing comms between you and kwray, you will need to complete some additional steps. Check with kwray in Slack.

@xingjitansuo LDN's may still be pulling from the v3 notary. We are still making the switch, and there will be a rollover period.

zcfil commented 1 year ago

@galen-mcandrew Hi，I want to know when I can change my wallet address

Trevor-K-Smith commented 1 year ago

Please know if additional action needed by me, reached out via slack again on march 8th.

zcfil commented 1 year ago

@galen-mcandrew Hi,My wallet address: f1cjzbiy5xd4ehera4wmbz63pd5ku4oo7g52cldga "Modified here, but not modified here:" https://filfox.info/en/address/f2yk6skf7mpk5mkp3bk5qyy5pmxgic6hfp55z2wcq Old wallet address: f17xummecmkqgjhm4fesktesaieumn7ugarwucwty New wallet address: f1cjzbiy5xd4ehera4wmbz63pd5ku4oo7g52cldga Please help me adjust, thank you

Kevin-FF-USA commented 1 year ago

@zcfil Confirming this new updated address in your application, will be manually adding you on to the multisig in the coming sprint

Kevin-FF-USA commented 1 year ago

@Trevor-K-Smith Confirming receipt of your updated address: f1437jngablusaizqizc6sxp4r5llioq7mp2eqlii. Will be adding to the multisig in coming sprint

GhostByteInc commented 1 year ago

@Trevor-K-Smith Confirming receipt of your updated address: f1437jngablusaizqizc6sxp4r5llioq7mp2eqlii. Will be adding to the multisig in coming sprint

Thank you Kevin!

zcfil commented 1 year ago

@zcfil Confirming this new updated address in your application, will be manually adding you on to the multisig in the coming sprint

Thank you Kevin! We have confirmed, please help me add the new address to MSIG

GhostByteInc commented 1 year ago

Hello, When time persists, i am awaiting f1437jngablusaizqizc6sxp4r5llioq7mp2eqlii to be added to the MSIG.

Ref: https://github.com/filecoin-project/notary-governance/issues/760

Thanks Team.

GhostByteInc commented 1 year ago

Hello, When time persists, i am awaiting f1437jngablusaizqizc6sxp4r5llioq7mp2eqlii to be added to the MSIG.

Ref: #760

@Kevin-FF-USA @galen-mcandrew

Hello, is there any update on adding this address into the multisig? I still do not see my address in there and respectfully still cannot perform any notary actions.

Waiting patiently for an update on this.