filecoin-project / ref-fvm

Reference implementation of the Filecoin Virtual Machine
https://fvm.filecoin.io/
Other
385 stars 140 forks source link

chore: upgrade rust toolchain to 1.78.0 #2006

Closed hanabi1224 closed 6 months ago

hanabi1224 commented 6 months ago
warning: bound is defined in more than one place
   --> ipld/hamt/src/node.rs:229:18
    |
229 |     fn get_value<Q: ?Sized, S: Blockstore>(
    |                  ^
...
239 |         Q: Eq + Hash,
    |         ^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
warning: unnecessary use of `get(&h2).is_none()`
   --> shared/tests/address_test.rs:584:16
    |
584 |     assert!(hm.get(&h2).is_none());
    |             ---^^^^^^^^^^^^^^^^^^
    |             |
    |             help: replace it with: `!hm.contains_key(&h2)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
hanabi1224 commented 6 months ago

@rvagg Good point, updated clippy warning details in the PR description.

rvagg commented 6 months ago

ah, those are nice lints, thanks