search

filecoin-project / ref-fvm

Reference implementation of the Filecoin Virtual Machine
https://fvm.filecoin.io/
Other
384 stars 139 forks source link

Optimization: remove hashing work from inside actors #374

Closed raulk closed 2 years ago

raulk commented 2 years ago

By generalizing the hash function https://github.com/filecoin-project/ref-fvm/issues/270. IIRC, HAMTs perform hashing inside Wasm.

Stebalien commented 2 years ago

See https://github.com/filecoin-project/ref-fvm/issues/270

raulk commented 2 years ago

See #636.

Stebalien commented 2 years ago

We also need to remove https://github.com/filecoin-project/builtin-actors/blob/ac3d3e8042ebe1c35e6249798b51f5aafdcd5a74/runtime/src/runtime/fvm.rs#L488.

raulk commented 2 years ago

@Stebalien that line is only enabled with fake proofs. I think we’re good.

Stebalien commented 2 years ago

Ah.... ok, back to the drawing board.

Stebalien commented 2 years ago

Fixed.