filecoin-project / ref-fvm

Reference implementation of the Filecoin Virtual Machine
https://fvm.filecoin.io/
Other
384 stars 139 forks source link

EVM Storage: No hashing in HAMT #890

Closed aakoshh closed 1 year ago

aakoshh commented 2 years ago

Part of https://github.com/filecoin-project/ref-fvm/issues/859 Depends on https://github.com/filecoin-project/ref-fvm/issues/888

The HAMT hashes keys before accessing the data to keep the tree size predictable and independent of key-size. This, however, is not needed for the EVM because the Solidity compiler already does hashing, and it's actually harmful for the layout of dynamic arrays which use offsets from an initial hash.

We should be able to create a HAMT for the EVM actor that doesn't hash the keys.

Stebalien commented 2 years ago

Also see #374

maciejwitowski commented 1 year ago

Closing as part of https://github.com/filecoin-project/ref-fvm/issues/859