search

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust
Other
492 stars 314 forks source link

Don't create the `sealed` file in precommit1 #1665

Closed magik6k closed 1 year ago

magik6k commented 1 year ago

Today precommit1 just copies unsealed bytes to the 'sealed' file, and does nothing else with them -> https://github.com/filecoin-project/rust-fil-proofs/blob/128f7209ec583e023f04630102ef1dd17fbe2370/filecoin-proofs/src/api/seal.rs#L91-L98

This leads to confusion, and redundant work on lotus side as it needs to manage that file between PC1/2.

Ideally Precommit1 would either not create the sealed file at all - that would happen in early PC2, or the sealed file would actually contain the correct, sealed data (in which case PC2 could possibly not require unsealed data access?)

vmx commented 1 year ago

This issue is about bundling to many things in the single precommit1 call. Those things have been split and are available through the FFI PR at https://github.com/filecoin-project/filecoin-ffi/pull/402.