feat(filecoin-proofs): add APIs for retrieving sealing and sector update keys

filecoin-project / rust-fil-proofs

Proofs for Filecoin in Rust

Other

489 stars 314 forks source link

feat(filecoin-proofs): add APIs for retrieving sealing and sector update keys #1682

Closed DrPeterVanNostrand closed 1 year ago

DrPeterVanNostrand commented 1 year ago

This PR adds:

SealPreCommitPhase1Output::sealing_key_path - returns path to "sealing key" (i.e. last layer)
SealPreCommitPhase1Output::read_sealing_key_range - returns a range of nodes of the sealing key
filecoin_proofs::api::update::read_sector_key_range - returns a range of nodes of the "sector update key" (i.e. the originally sealed sector, also called "old replica" within the context of sector updating)

Closes #1666 (and relates to #1667)

DrPeterVanNostrand commented 1 year ago

Hi @magik6k, if you have a chance, could you offer any feedback on this key retrieval API from a Lotus perspective?

Is retrieving a range of nodes from the sector update key sufficient, or would a different API be better for Lotus? I remember that you mentioned using file descriptors to retrieve keys, however that would require quite a bit of API refactoring.

DrPeterVanNostrand commented 1 year ago

Replaced by PR #1687